Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add drf e2e cases #905

Merged
merged 3 commits into from
Jul 6, 2020
Merged

add drf e2e cases #905

merged 3 commits into from
Jul 6, 2020

Conversation

Thor-wl
Copy link
Contributor

@Thor-wl Thor-wl commented Jul 4, 2020 •
edited
Loading

Signed-off-by: Thor 1187526662@qq.com

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 40cbb8e0-bdd8-11ea-a595-8f8781864445

@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 78ad5c60-bde1-11ea-a595-8f8781864445

@Thor-wl
add drf e2e cases
bf8c168 
Signed-off-by: Thor-wl <1187526662@qq.com>
@Thor-wl Thor-wl closed this Jul 6, 2020
@TravisBuddy
Copy link

Hey @Thor-wl,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ec8962a0-bf35-11ea-8212-0f9c14daf924

@Thor-wl Thor-wl reopened this Jul 6, 2020
hzxuzhonghu
hzxuzhonghu reviewed Jul 6, 2020
View reviewed changes
test/e2e/drf.go Show resolved Hide resolved
test/e2e/drf.go
job.name = "j2-drf"
job.tasks[0].req = halfCPU
backfillJob := createJob(ctx, job)
err = waitTasksReady(ctx, backfillJob, int(rep))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate how drf work in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drf works when a task who requires less resource and to be schedulered will preempt resource of another task who require more resource and is running

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comments

@Thor-wl
add copyright for test/e2e/drf.go
a3d2aac 
Signed-off-by: Thor <1187526662@qq.com>
hzxuzhonghu
hzxuzhonghu reviewed Jul 6, 2020
View reviewed changes
test/e2e/drf.go Outdated
@@ -0,0 +1,53 @@
/*
Copyright 2019 The Volcano Authors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2019/2020

@hzxuzhonghu hzxuzhonghu added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 6, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit d1cc54b into volcano-sh:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thor-wl @TravisBuddy @volcano-sh-bot @hzxuzhonghu